Skip to content

Add scan result policy name change banner

Alexander Turinske requested to merge revert-3d36cfae into master

What does this MR do and why?

Add scan result policy name change banner

  • When the security policy breaking changes were implemented for match_on_inclusion, even with the banner there was a lot of confusion. I removed this banner before the other breaking change because I didn't realize users would still be so surprised even with all the notices, so I am adding it back to account for that response.
  • Revert Remove scan result policy name change banner (!150058 - merged)
  • Show banner even if breaking changes feature flag is true

Remove scan result policy name change banner (!150058 - merged)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Banner Select
Screenshot_2024-04-25_at_15.18.55 Screenshot_2024-04-25_at_14.14.04

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Navigate to a project => Secure => Policies
  3. Verify the name change banner does display
  4. Verify the breaking changes banner displays
  5. Click "New policy"
  6. Verify the "Merge request policy" card does have an icon
  7. Verify the "Merge request policy" card does have a sub-title
Edited by Alexander Turinske

Merge request reports

Loading