Migrate snippet events to internal events
What does this MR do and why?
Related to #448290 (closed)
This migrates the counts.snippet_create
and counts.snippet_update
total count metric to Internal Events, while keeping the original Redis key. Instead of migrating the key to the new format in TotalCountMetric
, the new key is aliased in a YAML file and points to the old one, so that the count continues in the old key and we can keep the past count.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
- Checkout
master
and fire the event a few times (by creating and updating snippets). - Run in console and note the value:
definition1 = Gitlab::Usage::MetricDefinition.definitions['counts.snippet_update']
definition2 = Gitlab::Usage::MetricDefinition.definitions['counts.snippet_create']
[Gitlab::Usage::Metric.new(definition1).with_value, Gitlab::Usage::Metric.new(definition2).with_value]
- Checkout MR branch,
reload!
the console and run the previous point's code in the console again. The value should be identical. - Fire the event a few more times and make sure that the value got incremented.