Skip to content

Use safe navigation when accessing policy reads

Dominic Bauer requested to merge 458883-nomethoderror-undefined-method-fail_open-for-nil-nilclass-from-security into master

What does this MR do and why?

There's a race condition that can trigger when e.g. a security policy project is unassigned. It doesn't affect the functionality of fallback_behavior, but it will eat into our error budget.

Sentry: https://new-sentry.gitlab.net/organizations/gitlab/issues/776115/?project=3&query=fail_open&referrer=issue-stream&statsPeriod=14d&stream_index=0

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #458883 (closed)

Edited by Dominic Bauer

Merge request reports