Allow groups to be added to the inbound allowlist
What does this MR do and why?
For #415519 (closed)
Allow groups to be added to the inbound allowlist
Modify table to be usable for both groups and projects
Accept group paths in the form, use the mutation that can handle both
When removing, call either the group or project mutation
Add group count to table/card header
Update UI text that refers to projects to refer to groups and projects
Update tests
Changelog: added
Implementation plan
See #415519#implementation-plan
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Scenario | Before | After - see design for comparison - this doesn't fully match the design yet, there are more MRs to come |
---|---|---|
setting disabled |
changes: - toggle help text has been reworded and made into a description instead - deprecation alert has been reworded and moved above the table |
|
setting enabled |
changes: - table shows groups and projects with counts for each in the header - UI text now refers to groups and/or projects - delete buttons are no longer danger variant - table sub-header Project with access has been removed |
|
adding and removing items | Screen_Recording_2024-05-01_at_14.14.41 |
Screen_Recording_2024-05-01_at_14.09.10 changes: form accepts group paths, otherwise remains the same |
How to set up and validate locally
- navigate to a project
- in the sidebar, choose
Settings
=>CI/CD
- expand the
Token Access
section - disable the
Limit access to this project
toggle and make sure theNo access is currently allowed to this project...
alert is shown - enable the
Limit access to this project
toggle, the alert should go away - the following new actions should now be available:
- add a group to the allowlist (click
Add group or project
and pastegitlab-org
) - remove a group from the allowlist (click the delete button next to the group)
- add a group to the allowlist (click
- the following existing actions should still work:
- add a project to the allowlist (click
Add group or project
and pastegitlab-org/gitlab-test
) - remove a project from the allowlist (click the delete button next to the project)
- add a project to the allowlist (click
Edited by Miranda Fluharty