Add users table to pending promotion page
What does this MR do and why?
It adds a basic table to the pending promotion users page, showing: user, requested role, requester, date.
Note: there's no changelog associated with the MR since it's behind a feature flag.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
- Enable
member_promotion_management
feature flag - Enable
ApplicationSetting.first.update!(enable_member_promotion_management: true)
application setting - Use an Ultimate license, and simulate Ultimate SM setup (e.g.
export GITLAB_SIMLATE_SAAS=0 gdk restart
) - Visit any Group as an owner of that group (e.g.
http://127.0.0.1:3000/groups/gitlab-org/-/group_members
) - Promoting a non-billable GUEST member to a DEVELOPER role (this member should be non-billable on the whole instance, i.e. have a highest role as guest)
- You should see a banner saying "Role change request was sent to the administrator." — this means a promotion request has been created
- Navigate to the group's members
Related to #433174 (closed)
Edited by Ammar Alakkad