Skip to content

Check validity of added feature flag files only

Rémy Coutable requested to merge only-check-added-ff-files-with-danger into master

What does this MR do and why?

In the refactoring of !144174 (merged), I changed the logic to check the validity of added and modified FF files while we were only checking added FF files before.

This led to a bug when a FF file is renamed, since it's detected as "modified" but the old file isn't there anymore (see https://gitlab.com/gitlab-org/gitlab/-/jobs/6869070453#L772).

This was reported internally on Slack at https://gitlab.slack.com/archives/C02PF508L/p1715862808505969.

In this MR, we revert the validity checks to only happen on added FF files, and check the default_enabled attribute on modified files only. Ideally, we'd perform all checks on added and modified files, excluding renamed files.

I can do that as a follow-up.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Rémy Coutable

Merge request reports