Add milestone filter to Vue merge request list app
What does this MR do and why?
For #442917 (closed)
Adds the MR milestone filter to the Vue MR list search bar.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
- | Before | After |
---|---|---|
Filter option dropdown | ||
Filtered results | x |
How to set up and validate locally
- Enable the
vue_merge_request_list
feature flag in the rails consolerails c
=>Feature.enable( :vue_merge_request_list )
- Make sure that at least 1 MR has a milestone assigned (MRs with different milestones would be useful)
- Navigate to the Merge Request list e.g.
http://gdk.test:3443/[YOUR USERNAME]/[THE PROJECT NAMESPACE]/-/merge_requests
- Begin typing
milestone
in the search bar, and select themilestone
filter - Select one of your milestones that would include / exclude some MRs
- Submit the search / filter
- Try refreshing the page completely to test the URL search parameter on initial load
- Try clearing the milestone token filter and submitting that to see all the MRs become visible
Caveats
- We're not currently able to connect the negated milestone filter to the resolver, as we don't have a list of negatable filters
- Due to this, the
not
operator is removed from this implementation until the back end fully supports it
- Due to this, the
- The merge requests list backend does not yet support wildcard filters
- We have agreed to ship this without wildcards, since it's feature-flagged anyway.
Edited by Thomas Randolph