Skip to content

Move graphql requests to parent component

Alexander Turinske requested to merge 458824-move-graphql-requests into master

What does this MR do and why?

Move graphql requests to parent component

  • the policies are required in the parent level to check for invalid policies to pass to the header component
  • the list component has become very complex since there is a lot of logic, so moving the requests to the parent component will separate the concerns of retrieving the policies and displaying the policies
  • fix bug where changing the filter does not deselect the policy

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Navigate to a project => Secure => Policies
  3. If you have no polices, clone https://staging.gitlab.com/govern-team-test/policy-scan-profile and link this project to your project to use its policies
  4. Verify the policies load
  5. Verify the source and type filters work
  6. Verify when you select a policy, the drawer is closed when you change the filter or the linked security policy project
  7. Verify you can edit a policy

Related to #458824 (closed)

Edited by Alexander Turinske

Merge request reports

Loading