Skip to content

Fix display of performance bar in relative root installations

Lukas Eipert requested to merge leipert-fix-performance-bar-relative-url into master

What does this MR do and why?

Fix display of performance bar in relative root installations

Define new performance_bar entrypoint properly

With !151025 (merged) we introduced a new entrypoint for the performance bar. Unfortunately we didn't end up using it, because the webpack config pointed to ~/performance_bar/index.js instead of ~/entrypoints/performance_bar.js.

This resulted in the performance bar being broken in GitLab instances with relative root installations.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
before after

How to set up and validate locally

  1. Ensure you have webpack enabled in your GDK gdk stop ; gdk config set vite.enabled false ; gdk config set webpack.enabled true
  2. Set a relative root URL: gdk config set relative_url_root '/gitlab'
  3. gdk reconfigure && gdk restart
  4. Make sure to enable vite again: gdk stop ; gdk config set vite.enabled true ; gdk config set webpack.enabled false ; gdk reconfigure
Edited by Lukas Eipert

Merge request reports

Loading