Skip to content

Modify BackgroundMigrationBaseClass rubocop rule

Manoj M J requested to merge mmj-rubocop-fix into master

What does this MR do and why?

Based on the comment in !153675 (comment 1915757783).

We are having more and more background migrations that are being inherited from BackfillDesiredShardingKeyJob, instead of the usual BatchedMigrationJob class.

Examples: One, Two

BackfillDesiredShardingKeyJob is a subclass of BatchedMigrationJob, so the functionality and correctness will remain the same anyway. As we are creating more and more MRs this way using Housekeeper, it is less than ideal that we have to disable the rubocop rule in every MR.

This MR makes changes so that backfill migrations inherting from BackfillDesiredShardingKeyJob are okay.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Manoj M J

Merge request reports

Loading