Delegate GroupHook URL validation to base class
What does this MR do and why?
Delegate GroupHook URL validation to base class
GroupHook url validation requires urls to be both present and addressable. This prevents usage of masked sections in GroupHook URLs, behaviour which is supported for ProjectHooks.
This MR also removes an outdated sentence from the docs, as masked URL segments are now supported.
Changelog: fixed
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
- Create a group.
- In the group WebHook settings, create a hook with the following details:
- URL:
https://example.com/hook
- Mask portions of URL:
- Sensitive portion:
example.com
- How it looks:
url
- Sensitive portion:
- Trigger: emoji events
- Save the hook.
Existing behaviour: The hook doesn't save, and a URL validation error is presented. New behaviour: The hook saves and is functional.
Related issue: #460849 (closed)