Expose fields matching with FE
What does this MR do?
This MR changes JSON payload for MR widget to compare head and base reports. FE team need fields exactly same as defined here https://docs.gitlab.com/ee/api/vulnerabilities.html . We will still have added, fixed and existing reports but report entities have changed.
End points (they are not in use at the moment)
- http://<local_instance>/gitlab-org/ruby-bundler/merge_requests/<mr_number>/container_scanning_reports.json
- http://<local_instance>/gitlab-org/ruby-bundler/merge_requests/<mr_number>/dependency_scanning_reports.json
- http://<local_instance>/gitlab-org/ruby-bundler/merge_requests/<mr_number>/sast_reports.json
Before
After
Related issue: https://gitlab.com/gitlab-org/gitlab-ee/issues/13734
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Can Eldem