Skip to content

Add specs for issue query builder and filters

Terri Chu requested to merge tchu-improve-issue-query-builder-filter-specs into master

What does this MR do and why?

Related to #461872 (closed)

I realized before removing the FF for this that the by_authorization filter and IssueQueryBuilder was missing specs. I decided to add them in a new MR to make the removal smaller.

This MR:

  • adds very detailed specs for the by_authorization method. I feel this will greatly improve confidence if this code is refactored AND allow for quicker tests locally. We have the visibility feature specs that check permissions through role/permission tables but those are too slow to run locally.
  • adds more general specs for the IssueQueryBuilder to verify the query being built has the right named parts (but does not check the actual queries built).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

specs only

How to set up and validate locally

specs only

Edited by Terri Chu

Merge request reports