Skip to content

Add support for Redis extra config command to ActionCable

Balasankar 'Balu' C requested to merge redis-extra-config-command-actioncable into master

What does this MR do and why?

Add support for Redis extra config command added via !141681 (merged) to ActionCable's cable.yml also.

Omnibus GitLab counterpart - omnibus-gitlab!7672 (merged)

Closes: #465978

Testing

  1. Set up a Redis server behind a password

  2. Pass the Redis password to Rails via config_command, following https://docs.gitlab.com/omnibus/settings/configuration.html#provide-sensitive-configuration-to-components-without-plain-text-storage

  3. In Rails console, run the following command and ensure a "PONG" is returned (without this MR, ActionCable will fail to authenticate with Redis)

    ActionCable.server.pubsub.redis_connection_for_subscriptions.ping

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Balasankar 'Balu' C

Merge request reports