DB Load Balancing: Support SRV lookups
What does this MR do?
When doing service discovery for DB load balancing, support SRV lookup and the returned SRV records
https://gitlab.com/gitlab-org/gitlab-ee/issues/13732
Note CE changes - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32135
TODO
-
Parse database.yml for new record_type
(defaultA
, optional, can beSRV
) -
Update resolver lookup to use either Net::DNS::A
orNet::DNS::SRV
-
Parse answer - I think Net::DNS::Resolver
will returnNet::DNS::SRV
objects -
Construct hosts with ports -
Do something about weight
andpriority
- Document that we will ignore this, and continue round-robinning -
Ignore port if port is 0
? See https://gitlab.com/gitlab-org/gitlab-ee/issues/13732#note_207018113 -
Full local test, GDK issuing SRV will use secondaries - see https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/15558#note_207255986
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖