Skip to content

Fix custom role definition spec

Hinam Mehra requested to merge 450561-update-member-role-factory into master

What does this MR do and why?

  • Resolves #450561 (closed)
  • The test is flaky because of the Validation failed: Cannot create a member role with no enabled permissions
  • Its because custom_roles/definition_spec.rb wrote to the folder that has YAML files that defines all the custom roles. To fix this, we just updated the spec to not write to the folder.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Steps to reproduce

bundle exec rspec --order defined ee/spec/lib/gitlab/custom_roles/definition_spec.rb ee/spec/lib/ee/gitlab/access_spec.rb

Related to #450561 (closed)

Edited by Hinam Mehra

Merge request reports