Skip to content

Add the proper empty state when wiki page not found

Julia Miocene requested to merge wiki-404 into master

What does this MR do and why?

Problem: we say "Wiki doesn't exist" when the page doesn't exist but not the whole Wiki.

What was done here:

  • Add the proper empty state when wiki page not found
  • Show sidebar navigation

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
wiki_before_1 wiki_after_1

How to set up and validate locally

  1. Create a wiki for any public project
  2. Go to http://gdk.test:3000/admin/users/reported_user_1 or any other user with no groups and projects
  3. Click [Impersonate]
  4. Go to your created wiki
  5. Change the page name in the url
  6. See empty state page
  7. Don't forget to stop impersonating by clicking the icon near your avatar

#452225 (closed)

Fixes #22319 (closed)

Fixes #21891 (closed)

Edited by Himanshu Kapoor

Merge request reports

Loading