Skip to content

Add and backfill project_id for vulnerability_issue_links

Omar Qunsul requested to merge backfill-desired-sharding-key-small-table-vulnerability_issue_links into master

What does this MR do and why?

Add and backfill project_id for vulnerability_issue_links.

This table has a desired sharding key configured (view configuration).

This merge request is the first step towards transforming the desired sharding key into a sharding key.

This involves three changes:

  • Adding a new column that will serve as the sharding key (along with the relevant index and foreign key).
  • Populating the sharding key when new records are created by adding a database function and trigger.
  • Scheduling a batched background migration to set the sharding key for existing records.

Once the background migration has completed, a second merge request will be created to finalize the background migration and validate the not null constraint.

How to verify

We have assigned a random backend engineer from groupthreat insights to review these changes. Please review this merge request from a backend perspective. The main thing we are looking to verify is that the added column and association match the values specified by the desired sharding key configuration and that backfilling the column from this other table makes sense in the context of this feature.

When you are finished, please:

  1. Trigger the database testing pipeline as instructed by Danger.
  2. Request a review from the backend maintainer and database reviewer suggested by Danger.

If you have any questions or concerns, reach out to @tigerwnz or @manojmj.

This merge request was generated by a once off keep implemented in !143774

This change was generated by gitlab-housekeeper using the Keeps::BackfillDesiredShardingKeySmallTable keep.

To provide feedback on your experience with gitlab-housekeeper please comment in #442003 (closed).

Merge request reports