Use Security Dashboard in pipelines view
What does this MR do?
This replaces the Split Security Reports app with the Security Dashboard in the pipelines view. This is part of a larger effort to move security reports logic to the backend.
This is behind the pipeline_report_api feature flag, which is
currently disabled by default.
A few other related changes were made:
- Old references to "timeline" were replaced with "history" in specs
- DRY some specs regarding state initialisation
- Make the history and count endpoint props optional on the dashboard component, which, if missing/empty, disable the display of the counts and charts components
- Fixes a rendering discrepancy in the vulnerability modal, which was
displaying a
File: undefinedrow
Tracked by #13496 (closed).
Note
There will be merge conflicts to resolve once https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/15050 merges, which should happen before this one.
Screenshots
Pipeline view with pipeline_report_api disabled |
Pipeline view with pipeline_report_api enabled |
|---|---|
 |
 |
| Vulnerability modal before | Vulnerability modal after |
|---|---|
 |
 |
Note the extra Project and Report Type rows; this is due to the slightly different output of the Vulnerabilities API |
| Vulnerability (dismissed) modal before | Vulnerability (dismissed) modal after |
|---|---|
 |
 |
| Note the extra "at GitLab Org / security-reports" in the dismissal note; again, due to the different output of the Vulnerabilities API |
| Vulnerability (with file) modal before | Vulnerability (with file) modal after |
|---|---|
 |
 |
Note the File is no longer a link; this is due to a bug in the Vulnerabilities API
|
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation created/updated or follow-up review issue created
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
-
Separation of EE specific content
Performance and Testing
Edited by Mark Florian