Replace visualization designer's type selector component
What does this MR do and why?
Replace the product analytics visualization designer "type" GlDropdown
with a GlFormSelect
component.
This allows us to wire up an invalid state for the dropdown for form validation, and ensures we can focus the input correctly when the label is clicked.
The component has also been swapped to use v-model
to simplify/standardise/match the title input.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
(dropdown options, icons removed) | |
(form validation triggered) | |
(element focused when clicking on form label) |
How to set up and validate locally
- Follow these instructions to setup Product Analytics in GDK.
- Follow these instructions to onboard a project with product analytics if not already done
- Follow these instructions to configure custom dashboards for your project
- Visit the visualization designer at Project > Analytics > Analytics dashboards > Visualization deisigner
- Verify selecting chart type works as expected
Related to #427414 (closed)
Edited by Elwyn Benson