Skip to content

Remove click_element_coordinates

Sofia Vistas requested to merge sv-optimise-fill-element into master

What does this MR do and why?

We discovered that the fill_element method in the framework was considerably slower than using Chemlab or direct Capybara methods to fill out form elements.

This was found to be mainly due to click_element_coordinates within the method.

click_element_coordinates was originally added into fill_element as a way to stabilize flaky tests that interacted with pages that have GitLab keyboard shortcuts. At times, the tests were not focusing on the elements and would end up triggering a keyboard shortcut on the page instead. The tests have demonstrated to be stable enough without click_element_coordinates.

Promising results with improvements of 23% on pipeline duration for package-and-test, particularly on :orchestrated tests. test-on-gdk and test-on-cng show respective 2% and 3% improvements which explain since they don't run orchestrated scenarios.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sofia Vistas

Merge request reports