Skip to content

Attribution of caller_id and feature_category before callbacks

Hercules Merscher requested to merge controller-static-context-middleware into master

What does this MR do and why?

Resolves gitlab-com/gl-infra/scalability#3593 (closed).

This MR introduces an action controller middleware (behind a feature flag, disabled by default -- eventually to be removed) to populate the GitLab application request context, extracting the static annotations set in controllers and guaranteeing that values are set in the context before any controller method raises any error, thus not feeding the context with the feature_category and caller_id values (relevant for error budgets).

  • Some controller tests were refactored to request tests to guarantee that they won't fail in the process of removing the feature flag.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Hercules Merscher

Merge request reports