Skip to content

Use a single badge to show number of alerts on metrics dashboards

What changed?

  1. The alert label is now a badge component and has a max of 240px
  2. Alert label is moved closer to the chart title
  3. The loading spinner is moved to the right of Alert badge
  4. Chart title truncates if it is too long and shows a tooltip
  5. Clicking the alert badge shows alert modal.

Screenshots

Alert badges and long titles

Before After (Options icon is updated here)
Screen_Shot_2019-08-18_at_7.47.36_PM Screen_Shot_2019-09-12_at_2.27.52_PM

Multiple alerts badge (Options icon is not updated)

Screen_Shot_2019-09-11_at_5.42.38_PM

Does this MR meet the acceptance criteria?

Yes

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #12891 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading