Skip to content

Fix Changelog error on Non-encoded Commit Trailers

Olaoluwa Oluro requested to merge 467945-changelog-api-raises-exception-on-non-ascii-content-in-commit-trailers into master

What does this MR do and why?

Fix Changelog error on Non-encoded Commit Trailers

Problem

When a commit message is made with non-Ascii characters in the trailers, the changelog API returns a 500 when retrieved.

Solution

Ensure non-Ascii characters in commit trailers are encoded

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-07-02_at_20.41.39 Screenshot_2024-07-02_at_20.41.18

How to set up and validate locally

  1. Create an empty gitlab project
  2. Create an initial commit
  3. Create a second commit that contains a non-ascii character and also add a non-ascii trailer for example
Äpfel

Changelog: Äpfel
  1. See the changelog API return a 500 error, see the exception in the logfile.

Related to #467945 (closed)

Merge request reports