Skip to content

Fix GraphQL error of `pipeline.manualVariables`

Zhiyuan Lu requested to merge gitlab-jh/jh-team/gitlab:fix-graphqh-of-pipeline-variable into master
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do and why?

What

We introduced a bug in !155418 (merged) : GraphQL fields pipeline.manualVariables are not consistent with user permissions.

  • With sufficient permissions, pipeline.manualVariables supports five fields: key value id raw variableType
  • Without sufficient permissions, pipeline.manualVariables only supports two fields: key value

This problem does not affect any users for now, because no front-end page uses this field.

Why

It's pretty clear from the code why the problem occurred: we changed the Variable object to a Hash, which caused some fields to be lost.

image

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Marcel Amirault

Merge request reports