Skip to content

test: Add more time to spawn praefect

Eric Ju requested to merge eju/6196/spawn-praefect-error into master

What does this MR do and why?

Quite some test jobs failed because the praefect can't be connected. See gitaly#6196 (closed).

Our current observations are:

  1. The praefect process is spawned, and pid is not nil.
  2. The current timeout is 20s. The failed testing jobs timed out and dropped connection to praefect before praefect could take any request, that is why the `log/praefect-test.log" is empty.

This commit adds a private method process_details(). We use the method to print the process status before sending termination signal to the process. It is used to determine why praefect is not ready for connecting.

We also added a longer timeout before dropping praefect connection.

This may not certainly fix gitaly#6196 (closed), but it at least can give us more information about the praefect process when the error happens again.

Close gitaly#6196 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Eric Ju

Merge request reports

Loading