Draft: Update behavior of new note split button
What does this MR do and why?
Updates the behavior of the split button for adding a new comment so that clicking on the dropdown options takes immediate action instead of changing the configuration of the button to the left of the dropdown.
This MR was spurred on by a discussion in Slack about the expected pattern for split buttons that perform an action.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
How to set up and validate locally
- Check out this branch
- Visit an issue or an MR in the GDK
- Type some text in the comment field at the bottom of the activity feed
- Click the "Comment" button. Your comment will be posted.
- Type another comment and use the dropdown on the split comment button. Choose the first option, "Comment". Your comment will be posted.
- Type another comment and use the dropdown on the split comment button. Choose the second option, "Start thread". Your comment will be posted as the start of a thread.
- On an MR, start a review by replying to an existing comment.
- While in the pending review state...
- Compose a new comment at the bottom of the activity feed. Click "Add comment to review". Your comment will be added to the pending review.
- Compose another new comment and use the dropdown on the split comment button. Choose the first option, "Comment". Your comment will be added to the pending review.
- Compose another new comment and use the dropdown on the split comment button. Choose the second option, "Start thread". Your comment will be added to the pending review.
- Compose another new comment and click "Add comment now". Your comment will be immediately added, and will not be pending.
- Compose another new comment and click "Add thread now". Your comment will be immediately added as the first comment in a new thread and will not be pending.
- Finish your review. You will see that all the pending comments are posted, and the comment added in step 8.3 above will be the first comment in a new thread.