Skip to content

Your Work Projects - Fix improper index import

Zack Cuddy requested to merge 472639-proper-project-dashboard-import into master

What does this MR do and why?

Closes #472639 (closed)
Resolves E2E quarantine: https://gitlab.com/gitlab-org/gitlab/-/issues/469562

There was conflicting JavaScript imports in the /page level for both pages/dashboard/projects/index.js and pages/dashboard/projects/index/index.js. This change consolidates the two into pages/dashboard/projects/index.js. This resolves the bug where the ProjectsList wasn't being included at the / path as well as preserved the new feature flag based import for the Vue Project list.

Screenshots or screen recordings

Before After
Legacy Project List - Root Path (bug fix) BEFORE_FF_Disabled_-_Root AFTER_FF_Disabled_-_Root
Legacy Project List - Dashboard Path BEFORE_FF_Disabled_-_Dashboard AFTER_FF_Disabled_-_Dashboard
Vue Project List - Root Path BEFORE_FF_Enabled_-_Root AFTER_FF_Enabled_-_Root
Vue Project list - Dashboard Path BEFORE_FF_Enabled_-_Dashboard AFTER_FF_Enabled_-_Dashboard

How to set up and validate locally

Note: The goal of testing here is to validate the javascript is properly importing at all locations. As well as validating the bug fix.

Testing the bug

  1. Disable the Feature Flag :your_work_projects_vue
  2. Navigate to the root path ex. http://127.0.0.1/
  3. Type something in the Filter by Name at the top of the page
  4. Ensure that it searches after a debounce without striking the enter key
  5. Repeat for the dashboard paths ex. http://127.0.0.1/dashboard and http://127.0.0.1/dashboard/projects

Validating Feature Flag still works

  1. Enable the Feature Flag :your_work_projects_vue
  2. Navigate to the root path ex. http://127.0.0.1/
  3. Ensure you are now greeted with a simple WIP tab layout and tabs work
  4. Repeat for the dashboard paths ex. http://127.0.0.1/dashboard and http://127.0.0.1/dashboard/projects

Related to #472639 (closed)

Merge request reports

Loading