Skip to content

Use semantic tokens in diff_file_component.scss

Chad Lavimoniere requested to merge 472908-use-semantic-tokens-in-app-assets-stylesheets-components-rapid_diffs-diff_file_component-scss into master

What does this MR do and why?

Use semantic tokens in diff_file_component.scss

Note that there are outstanding tokenizable color usages in this file that rely on semantic tokens that don't exist (for red and green usage on removed/added lines).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

(Note: there is no visual change)

Before After
gdk.test_3000_flightjs_Flight_-merge_requests_28_diffs_rapid_diffs_true__1 gdk.test_3000_flightjs_Flight_-_merge_requests_28_diffs_rapid_diffs_true

How to set up and validate locally

  1. Check out this branch
  2. Turn on the rapid_diffs feature flag in your GDK
  3. Visit an MR that has changes
  4. Add the query rapid_diffs=true to the URL
  5. You will see the "rapid diff" diff style
    • Note: there is no visual difference in the browser for the current change

Related to #472908 (closed)

Merge request reports