Skip to content

Add phone type details to Telesign log messages

Ian Anderson requested to merge ia-telesign-blocked-number-logging into master

What does this MR do and why?

Closes: https://gitlab.com/gitlab-org/modelops/anti-abuse/team-tasks/-/issues/808

This MR adds phone_type details to Telesign log messages. These details will help support determine why a phone number may have been blocked.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Start GDK with SaaS simulation

    $ export GITLAB_SIMULATE_SAAS=1
    $ gdk start
  2. Setup Telesign

    ApplicationSetting.first.update(telesign_customer_xid: '<value_is_in_1Pass>', telesign_api_key: '<value_is_in_1Pass>')

    Credentials are in 1Password under Telesign API Keys (use GITLAB - DEVELOPMENT)

  3. Tail the application logs

    tail -f log/application_json.log| grep 'PhoneVerification::TelesignClient::RiskScoreService'
  4. Execute the PhoneVerification::TelesignClient::RiskScoreService. You should see a log emitted with the telesign_phone_type and valid_phone_type keys.

    PhoneVerification::TelesignClient::RiskScoreService.new(phone_number: '12252542523', user: User.last, ip_address: '1.1.1.1').execute 
Edited by Ian Anderson

Merge request reports

Loading