Skip to content

Don't run `update-tests-metadata` if needed jobs failed

Lin Jen-Shin requested to merge dont-update-metadata-when-needed-failed into master

What does this MR do and why?

Don't run update-tests-metadata if needed jobs failed

If we run it when needed jobs failed, we can be missing metadata from those failed jobs.

We noticed this from https://gitlab.com/gitlab-org/gitlab/-/jobs/7393244546 where it's not downloading artifacts from rspec:artifact-collector unit and rspec:artifact-collector ee unit, because those collectors were skipped, and they're skipped because their respective jobs failed. That is, some unit test jobs failed.

This became a more obvious problem after !159241 (merged) because with dependencies on each individual jobs, we're just missing a few failed jobs, but now with the collectors we're missing a whole set of jobs.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Lin Jen-Shin

Merge request reports

Loading