Skip to content

Use semantic tokens in app/assets/stylesheets/framework/blocks.scss

Chad Lavimoniere requested to merge 473815-use-semantic-tokens-in-app-assets-stylesheets-framework-blocks-scss into master

What does this MR do and why?

Use semantic tokens in app/assets/stylesheets/framework/blocks.scss and remove dead code

Removes

  • .row-header-content.white. This does not occur in the app anywhere. This style was used 8+ years ago.
  • .landing .dismiss-button. This odes not occur in the app anywhere. This is a remnant from a style used 5+ years ago.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

(Note: no visual change)

Before After
gdk.test_3000_flightjs_sentry-test__1_ gdk.test_3000_flightjs_sentry-test

How to set up and validate locally

  1. Check out this branch locally
  2. In the GDK, set your user preference to show wiki content for the project overview (Preferences > Behavior > Project overview content)
  3. Visit a project that does not have a wiki set up
  4. You will see the This project does not have a wiki homepage yet landing page block

Related to #473815 (closed), #452231 (closed)

Edited by Chad Lavimoniere

Merge request reports