Skip to content

Ignore unknown sequences in sequence fix migration

Stan Hu requested to merge sh-skip-unknown-sequences-migration-issue-474293 into master

What does this MR do and why?

GitLab 17.2.1 included a migration to fix the wrong owners of sequences (!160139 (merged)). Unfortunately due to a bug in the sequences_owned_by query described in #468541 (comment 2013158432), some sequences may have been assigned the wrong owner and not automatically dropped when its associated table was dropped.

For example, for one customer geo_reset_checksum_events_id_seq was assigned to the wrong owner (p_ci_builds.partition_id), so when geo_reset_checksum_events was dropped in GitLab 17.0 via !151938 (merged), the sequence remained in the database. We could remove these unused sequences, but that should probably be done by a different migration (UPDATE: done in !160624 (merged)). For now, ignoring these sequences is the safest way to handle this.

Relates to #474293 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stan Hu

Merge request reports