Replace `text-tertiary` with `gl-text-tertiary`
requested to merge 473840-use-semantic-tokens-in-app-assets-stylesheets-framework-common-scss-text-tertiary into master
What does this MR do and why?
The text-tertiary class defined in common.scss is not necessary. The
tailwind util class gl-text-tertiary can be substituted for it
directly. There are also places where we can use other classes like gl-text-subtle instead.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Many places in the app did not have any visual change from this, but a few that did change are listed below:
| Thing that changed | Before | After |
|---|---|---|
| Operations dashboard alerts icon |  |
 |
| Milestone list items (dates and releases) |  |
 |
| Suggested similar issues results on new issue page (the up/downvote and comment count icons changed) |  |
 |
| Pipeline wizard page description (beneath header) |  |
 |
How to set up and validate locally
Examples of text tertiary are plentiful, but one easy to spot one is the date ranges on a milestone in the milestones list page.
- Check out this branch
- Visit a project or group's milestones list page (for example, http://gdk.test:3000/flightjs/Flight/-/milestones)
- Inspect the date ranges for a milestone that has a start and/or due date (if none have any, add dates to one)
- You will see that it has class
gl-text-subtle
Related to #473840, #452231 (closed)
Edited by Chad Lavimoniere