Skip to content

Clean up feature flag add_gitlab_tier_cookie

Roy Liu requested to merge 462434-ff-cleanup-add_gitlab_tier_cookie into master

What does this MR do and why?

Remove add_gitlab_tier_cookie flag, the feature has been running in production for a month now: #462434 (comment 1953668942).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

The gitlab_tier cookie is set up when a user logs into .com

  1. Locally, authenticate to .com GitLab as the root admin user and make sure you are simulating a SaaS instance.
  2. Create a few groups and change their plans under the admin -> groups -> edit that group. Change the plan for a few groups. That cookie should not be present.
  3. Sign out of GitLab in your local dev environment. Verify that the cookie is not present.
  4. Log in again to that same root user. You should see the correct tiers for the group's billing that you changed. Free/Premium/Ultimate should be reflected in that cookie.

Related to #462434 (closed)

Edited by Roy Liu

Merge request reports