Skip to content

Fix false rspec pending warning

Rutger Wessels requested to merge 411832-remove-false-pending-warning into master

What does this MR do and why?

After the merge of !155732 (merged), a "not yet implemented" warning showed when running a rspec file

  1) Gitlab::BackgroundMigration::NullifyParentIdForNamespaces 
     # Not yet implemented
     # ./spec/support/helpers/disable_namespace_organization_validation_helper.rb:24

It is related to the usage of the example method. It seems like it was creating an empty example group. This empty group did not have an implementation so hence the warning.

This MR will no longer use example but the metadata of the actual spec file. The warning is gone

As a bonus, the logic for getting a absolute path for the spec file is simplified.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #411832 (closed)

Edited by Rutger Wessels

Merge request reports