Skip to content

Allow submit service to accept JSON header

Nwanna Isong requested to merge nisong-allow-submitservice-accept-json-header into master

What does this MR do and why?

This MR addresses this issue It modifies the submit service to accept json header response, this solves the issue of when response comes back a html from the version app and could cause issues.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. In the Versions app, turn off the code that automatically returns a json response
  2. In the Gitlab app's rails console, run GitlabServicePingWorker.new.perform('triggered_from_cron' => false) to trigger a service ping
  3. Check that the response is in json format
Edited by Nwanna Isong

Merge request reports