Skip to content

Explicitly set Organization when using Groups::NestedCreateService

Rutger Wessels requested to merge 411832-enable-validation-for-nested-create-service into master

What does this MR do and why?

In !155732 (merged), we added validation for presence of an Organization on Namespaces. Since this MR was already quite big and impactful, most 'Create Namespace' code paths are wrapped in a Namespace.with_disabled_organization_validation method, which caused the validation to be skipped.

This MR will pass an organization_id to the parameters of the Groups::NestedCreateService.new method.

  • In controllers, we use Current.organization (See !158626 (merged))
  • For Manifest Import, use the organization of the destination group

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #411832 (closed)

Edited by Rutger Wessels

Merge request reports