Skip to content

Move provider selection component error state inline

Elwyn Benson requested to merge 474938-move-onboarding-error into master

What does this MR do and why?

Moves the product analytics onboarding flow provider selection component error state inline

  • don't bubble error up to parent component
  • display error in context
  • hide "Options" header when there is an error

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

  1. Follow these instructions to setup Product Analytics in GDK. (for this specific MR, since we're dealing with the onboarding flow and the error state, you don't actually need to run the full analytics devkit docker stack, just the changes within GitLab to get into the onboarding flow itself are required)
  2. Create a new project / visit a not-onboarded project.
  3. Ensure you are signed in as a maintainer or higher role.
  4. Visit Project > Analytics > Analytics dashboards.
  5. Open devtools and view network panel. Disable network connection to cause the next network request to fail.
  6. Click "Set up".
  7. Verify error state has moved as expected.

Related to #474938 (closed)

Edited by Elwyn Benson

Merge request reports

Loading