Skip to content

Add expected body for stubbed Arkose API request

Ian Anderson requested to merge ia-arkose-verify-api-specs into master

What does this MR do and why?

Closes gitlab-com/gl-infra/production-engineering#25653 (closed)

This MR improves the spec for the Arkose verify API request. Due to an incident an MR that refactored the Arkose::TokenVerificationService had to be reverted due to errors. The error was due to the request being converted from a form post to a JSON request. When the content-type was changed to JSON one of the request fields was sent as an integer instead of a string, resulting in 400 errors from the API. If our stubbed request in this spec had validated the request body then this would have been caught during development.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Ian Anderson

Merge request reports