Skip to content

Removes the carousel from the app

Sam Beckham requested to merge bye-bye-carousel into master

What does this MR do and why?

This MR removes the <GLCarousel> component from the security discovery page. We're deprecating this component and need it removed. This provides a still-working alternative whilst we iterate towards a better solution for this page.

It also removes looooads of crud from the app that was propping this component up.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Screen_Recording_2024-07-31_at_10.46.39

Before After
Screenshot_2024-07-31_at_10.44.44 Screenshot_2024-08-01_at_17.33.19

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Go to ee/app/controllers/projects/security/discover_controller.rb
  2. Comment out lines 11-13
  3. Go to http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/security/discover or an equivalent in your GDK.
Edited by Sam Beckham

Merge request reports