Skip to content

StageCheck true when VR GA FF is enabled

Darby Frey requested to merge remove-rv-experiment-check into master

What does this MR do and why?

As part of https://gitlab.com/gitlab-org/gitlab/-/issues/476551+, specifically No experimental/beta control required, this MR updates the Gitlab::Llm::StageCheck to return true for VR when the vulnerability_resolution_ga feature flag is enabled. This will provide the ability to rollout the GA version of VR via the feature flag.

With the feature flag disabled, it is necessary for the Use experiment and beta Duo features setting to be enabled for VR to be available to a project.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

The table below shows the expected button state for different configurations:

Configuration Expected Button
vulnerability_resolution_ga FF disabled, Use experiment and beta Duo features unchecked Screenshot_2024-08-01_at_3.09.48_PM
vulnerability_resolution_ga FF disabled, Use experiment and beta Duo features checked Screenshot_2024-08-01_at_3.13.27_PM
vulnerability_resolution_ga FF enabled, Use experiment and beta Duo features unchecked Screenshot_2024-08-01_at_4.38.05_PM
vulnerability_resolution_ga FF enabled, Use experiment and beta Duo features checked Screenshot_2024-08-01_at_4.38.05_PM
Edited by Darby Frey

Merge request reports