Remove 'disable validation' from CreateRunnerService
What does this MR do and why?
In !155732 (merged), we added validation for presence of an Organization on Namespaces. Since this MR was already quite big and impactful, most 'Create Namespace' code paths are wrapped in a Namespace.with_disabled_organization_validation
method, which caused the validation to be skipped.
This will remove the exception for Ci::Runners::RunnersCreateService
. The exception was added because Projects and Groups did not have an organization assigned in test context. But now they have. So creating a Runner in test context will now work.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Test
Using Gdk:
- Create runner using http://gdk.test:3000/flightjs/Flight/-/runners/new
- Ensure the runner is created in the database
Related to #411832 (closed)
Edited by Rutger Wessels