Skip to content

Validate user before passing to PersonalProjectsFinder

Rutger Wessels requested to merge rw/fix-invalid-user-500 into master

What does this MR do and why?

A few http error 500's were raised related to ChildController. See gitlab-com/gl-infra/production#18362 (closed)

This was caused because an invalid User object was passed.

This MR will return an empty Project relation if the user argument is not a User instance. This should prevent errors related to policy checking.

Related Issue gitlab-com/gl-infra/production#18362 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports