Skip to content

Resolve StrongParams rubocop TODOs for some admin controllers

Nick Malcolm requested to merge 477392-resolve-admin-strongparams-exceptions into master

What does this MR do and why?

Resolve StrongParams rubocop TODOs for some admin controllers

Many admin controllers use params directly without using Rails' StrongParameters helper. This causes Rubocop exceptions, which were ignored when the rubocop was introduced in !155661 (merged)

This commit addresses offenses in some of the admin controllers. In simple cases, we call permit directly in-line. Where the parameters are being accessed in multiple locations, a helper method is introduced.

Resolves #477392 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #477392 (closed)

Merge request reports