Protected packages + containers: Define spacing in parent element
requested to merge gitlab-community/gitlab:467718-gerardo-navarro-protected-containers-badge-protected-in-container-registry-list-follow-up-style-gap-on-parent into master
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA
What does this MR do and why?
- This follow-up MR is a suggestion that comes from another MR review
- Move style regarding spacing to the parent element
- This MR waits for !158600 (merged) to be merged
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
MR Checklist (@gerardo-navarro)
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the javascript style guides -
Conforms to the database guides
Screenshots or screen recordings
No frontend change. The intention was that the styling stays the same.
Scenario 1: Badge "Cleanup" and badge "protected"
| Before | After |
|---|---|
 |
 |
Scenario 2: Only badge "protected"
| Before | After |
|---|---|
 |
 |
Scenario 3: Tags and Badge "protected" in package registry
Only minimal spacing changes.
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
- Enable the container registry in you local gdk
- Push a container image for a container respository path
- Go to the container repository overview page: http://gdk.test:3000/flightjs/Flight/container_registry
- In the table, you should see a table entry for the pushed container repository, but without the badge "protected"
- Go to the project settings and protect a certain container repository: http://gdk.test:3000/flightjs/Flight/-/settings/packages_and_registries
- Go to the container repository overview page: http://gdk.test:3000/flightjs/Flight/-/settings/packages_and_registries
- In the table, you should see a table entry for the pushed container repository with the badge "protected"
You follow the similar steps to validate the package registry.
Related to #467718 (closed)
Edited by Gerardo Navarro