Skip to content

Use large timeout to ensure no flaky banzai specs

Brett Walker requested to merge bw-increase-banzai-filter-spec-timeout into master

What does this MR do and why?

We occasionally have flaky specs due to using Timeout.timeout to test the handling of malicious inputs for Banzai filters. In order to ensure this does not happen, use a large timeout value. This ensures that a test won't suddenly become exceedingly long, but it doesn't really protect against a spec going from 1 second to 15 seconds.

Ideally we find a better way/metric for these types of tests.

See #475039 (comment 2024746601)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Brett Walker

Merge request reports

Loading