Update labelling of empty MR approval rules
What does this MR do and why?
This MR solves the first point of #470701:
Update the labelling of "All eligible users" as "Approvers" and make the rule name "Minimum required approvals"
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Settings / Merge requests / MR approval rules
| Viewport size | Before | After |
|---|---|---|
xs (<576px) |
 |
 |
lg (>=992px) |
 |
 |
Settings / Repository / Branch rules / Details
There should be no changes and no regression for this view.
| Viewport size | Before | After |
|---|---|---|
xs (<576px) |
 |
 |
lg (>=992px) |
 |
 |
Project / Merge requests / Merge request edit
| Viewport size | Before | After |
|---|---|---|
xs (<576px) |
 |
 |
lg (>=992px) |
 |
 |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
-
In rails console enable the experiment fully
Feature.enable(:edit_branch_rules) -
Go to Project / Settings / Repository / Branch rules and click View details for a rule
-
Scroll down to Merge request approvals section. Make sure there's no regression.
-
Go to Project / Settings / Merge requests and scroll down to Merge request approvals section. Make sure the first default rule has Rule and Approvers columns filled.
-
Go to Project / Merge requests / Merge request and edit any MR. Scroll down to Approval rules section. Make sure the first default rule has Rule and Approvers columns filled.
Related to #470701