Fix wrong project in the connect command for agent cluster
What does this MR do and why?
This MR fixes the wrong project showing up in the connect command introduced by !161092 (merged). We should use the project where the agent's configuration lives and not the current project.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Prerequisites:
- NGINX, loopback interface, and HTTPS set up on your GDK
- Docker instance
- KAS enabled on GDK (steps 1-2 from the guide).
-
Visit the Project -> Operate -> Kubernetes clusters page and create an agent following the instructions from the modal.
- Select the "Connect a cluster" button
- The modal should pop up
- In the modal select "Select an agent or enter a name to create new"
- You probably won't have any configured agents to show up in the list, create a new one by typing the name of your choice
- The button should appear at the bottom of the list saying "Create agent:
<your-agent-name>
" - Select the button and click "Register" in the next view.
- Save the token to use it in the next point.
-
Visit Project -> Operate -> Kubernetes clusters page and check out the actions menu
-
Click on an agent name to navigate to individual agent page
-
Add the following configuration inside your project in
.gitlab/agents/<your-agent-name>/config.yaml
for the user_access agent:user_access: access_as: agent: {} projects: - id: <your-group>/<your-project-to-share-agent-with>(select another project)
-
Visit cluster page for the project you've shared your agent with and select Connect to from the actions menu
-
Verify the connect command in the modal shows the agent's project and not the project you're currently in.
To verify the change on the Environment page:
- Note that the shared agents should be connected to the cluster in order to appear in the list. Please follow points 3-8 from the guide and then the Deploy the GitLab Agent (agentk) with k3d section to create a local cluster and connect your agent with the cluster.
- Follow this guide to setup internal events logging locally
- Visit Project -> Operate -> Environments
- Create/Edit an environment using the UI
- Select an agent from the dropdown in the Environments settings page and save the change.
- Visit the Environments page and visit the environment details page for the environment that has an associated agent.
- Verify the connect action in the actions menu
Related to #463769 (closed)