Skip to content

Replace subtle text color style with description label default style

Vanessa Otto requested to merge replace-text-gl-muted into master

What does this MR do and why?

We need to remove text-gl-muted from GitLab, because we want to remove this CSS Class in GitLab UI in this MR gitlab-ui!4463 (closed)


Replace subtle text color style with description label default style

Changelog: changed EE: true


My initial idea was to replace text-gl-muted. But then, I thought of the discussion we had: gitlab-ui!4463 (comment 2026997482). And I thought, this should actually be a labelDescription (with default text color) and not a description (with subtle text color). This is why I replaced the existing CSS classes with the one from Bootstrap for the labelDescription:

Screenshot_2024-08-07_at_16.48.26

Let me know what you think!

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-08-07_at_15.38.30 Screenshot_2024-08-07_at_16.48.58

How to set up and validate locally

Generally you can follow the steps !152380 (merged). Because I had some problems for a while, I used this workaround:

  1. Go to the feature_settings_controller controller
  2. Remove the method ensure_feature_enabled!
  3. Go to the URL http://gdk.test:3000/admin/ai/feature_settings
  4. If it asks you to enable specific feature flags, enable them
  5. Go to the subpages linked here
Edited by Vanessa Otto

Merge request reports

Loading